Check if the container owner really exists - #1600
Open
mtwango wants to merge 1 commit into
Open
Conversation
Member
Author
|
I wasn't able to reproduce, how to make it bugout, but some chests, that we have on ground produces this issue while others doesn't. Even when they have more, more2, link and baseid same, one produces critical and the other one doesn't. However this check shouldn't cause any issues, since if the owner is found, it calculates like normally and when not, the calculation is skipped. |
Contributor
|
Yup had this issue too long time ago. |
JulianUO
added a commit
to JulianUO/UOAscension-SphereX
that referenced
this pull request
Sep 13, 2026
…and gameplay mechanics - Integrated PR Sphereserver#1327: CLOSECONTAINER and CLOSEVENDORMENU client verbs - Integrated PR Sphereserver#1590: CV_NUKE refactor and CV_NUKEITEM command - Integrated PR Sphereserver#1589: PingFloodMax speedhack detection on packet 0x73 - Integrated PR Sphereserver#1587: NAME.PREFIX / NAME.SUFFIX in addItemName - Integrated mtwango/edebaa6: lingering character reconnect handling - Integrated PR Sphereserver#1568: immediate weather, light, and season sync on sector change - Integrated PR Sphereserver#1566: optional bell curve parameter for SKILLCHECK - Integrated PR Sphereserver#1600: safe dynamic_cast container owner check in CanContainerHold - Integrated PR Sphereserver#1497: robust bitmask memory clear preserving MEMORY_IPET/MEMORY_FRIEND - Integrated PR Sphereserver#1523: corpse item count and weight filtering for hair and special flags - Integrated PR Sphereserver#1535: fix NpcLookAroundChance clamping and probability evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checked container doesn't have an owner, it produces the following critical:
This PR checks for owner and it there is none, it doesn't calculate the option to carry more weight.