Add a manufacturer landing page to the probe viewer#64
Draft
h-mayorquin wants to merge 6 commits into
Draft
Conversation
…'s contacts with a per-probe zoom cap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewer opened straight onto a hard-coded default probe, giving no overview of what the catalog holds. This adds a landing page at the root: one card per manufacturer (logo and probe count). Selecting a card enters the existing sidebar-and-viewer on that manufacturer's first probe, and a Home control in the sidebar returns to the landing. Browsing within a manufacturer is unchanged; this only changes what you see before picking one.
I also made a few other viewer improvements on this branch. Probes now open fitted to their contacts (a "Full Contacts View", used as the default) rather than to the whole probe outline, which matters for probes whose electrodes occupy a small band of a long shank. The maximum zoom is now computed per probe so the smallest contact can roughly fill the viewport, instead of a single global constant that meant very different things for a 3 mm probe versus a 90 mm one. And the shared-link URL now carries the view toggles (contact IDs, scale bar, overview), so a shared view reproduces what the sender was looking at. These are independent of the landing page, so I can split them into their own pull request if you prefer.
On the logos: the six cards use the manufacturers' own marks to identify their products in the catalog (nominative use). A brand-colored wordmark fallback remains in the code, so any logo can be dropped without affecting the layout.