Fix read_mclust returning zero units for .t files#4626
Merged
alejoe91 merged 2 commits intoJun 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in
MClustSortingExtractormaderead_mclustsilently return a sorting with zero units for plain.tfiles (reported in #4602). First, the extension search relied on the truthiness ofPath.glob(...), which returns a generator and is therefore always truthy, so the format was always detected ast64regardless of which files were present; materializing the glob withsorted(...)makes the check reflect what is actually on disk. Second, MClust 3.x writes big-endian uint64 timestamps into the plain.tsuffix while the reader assigns uint32 to any non-64extension, so each 64-bit value was read as two 32-bit words; dropping the zero high words (only for thetfamily read as uint32) recovers the timestamps, matching the community reference loader.Closes #4602.