fix(popover): Fix popover focus-leave dismissal#2298
Open
alexwarren wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: b63f473 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks fixes to address A11Y-160
Summary
s-popoverwhen keyboard focus leaves both the trigger and popover, but only for popover content marked withrole="menu".Why
A11Y-160 reports that dropdown/popover menus remain visually and programmatically expanded after users tab away. This keeps
aria-expandedtrue even though focus has moved outside the trigger/popover pair.Stacks popovers remain a low-level primitive, so the new dismissal behavior is derived from menu semantics instead of applying to dialogs or generic popover content.
Validation
npm run test:unitinpackages/stacks-classic: 30 passing across Chromium, Firefox, and WebKit.npx web-test-runner --config web-test-runner.config.mjs --files src/components/Popover/Popover.test.tsinpackages/stacks-svelte: 43 passing.npx web-test-runner --config web-test-runner.config.mjsinpackages/stacks-svelte: 572 passing.npx svelte-check --tsconfig ./tsconfig.json: 0 errors/warnings.