chore: update various image assets including app icons and favicons - #3
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟡 Changes recommended
The updated documentation includes a grammatical truncation and the change appears out of scope relative to the PR title, which should be corrected for clarity and traceability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the development environment documentation to clarify how custodial mnemonic encryption works in production (Google Cloud KMS) vs local development (CUSTODIAL_DEV_SECRET), including key-version-specific AAD behavior.
Changes:
- Expand the production KMS note to document AAD behavior for key version 1 vs 2+.
- Describe the AAD binding format used for version 2+ and how older rows are re-wrapped.
File summaries
| File | Description |
|---|---|
| content/docs/develop/environment.mdx | Expands env-var documentation with production KMS/AAD details for custodial mnemonic encryption. |
Review details
- Files reviewed: 1/8 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | `DISABLE_VERIFICATION` | yes (local) | Skip signup email OTP UI + disposable-email checks | `true` / unset / `false` | | ||
|
|
||
| Production encrypts custodial mnemonics with **Google Cloud KMS** instead of `CUSTODIAL_DEV_SECRET` | ||
| Production encrypts custodial mnemonics with **Google Cloud KMS** instead of `CUSTODIAL_DEV_SECRET`. Key version 1 has no AAD; version 2+ binds `wallet:{userId}:stacks:{network}`. Version-1 rows are re-wrapped on the next successful sign. |
| | `DISABLE_VERIFICATION` | yes (local) | Skip signup email OTP UI + disposable-email checks | `true` / unset / `false` | | ||
|
|
||
| Production encrypts custodial mnemonics with **Google Cloud KMS** instead of `CUSTODIAL_DEV_SECRET` | ||
| Production encrypts custodial mnemonics with **Google Cloud KMS** instead of `CUSTODIAL_DEV_SECRET`. Key version 1 has no AAD; version 2+ binds `wallet:{userId}:stacks:{network}`. Version-1 rows are re-wrapped on the next successful sign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.