Feat/add animations to game actions - #10
Merged
Merged
Conversation
… Checkers and Ludo
…ing visual consistency and interactivity
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates several game rooms and shared UI to add motion cues (pulsing/nudging highlights) and to make turn timers/shot clocks render only for the active player.
Changes:
- Update
TurnBarbehavior so the shot clock only renders on your turn, and adjust game rooms to passtimeoutSecsaccordingly. - Add new global animation keyframes/utilities and apply them to actionable UI elements (roll button, movable pieces/pawns).
- Improve some in-room UX flows (e.g., Ludo move value ordering, brief hold to read “no-move” rolls; Checkers allows switching selection mid-turn).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| games/shared/turn-bar.tsx | Makes the shot clock conditional on isYou and non-null/positive timeoutSecs. |
| games/ludo/room.tsx | Adds engine-driven shot clock state, “no-move roll” hold, value ordering, and action animations. |
| games/ludo/board.tsx | Adds animated/outlined styling for movable pawns and refactors pawn markup. |
| games/lexi-wars/room.tsx | Passes timeoutSecs only on the local player’s turn; adjusts resetKey. |
| games/checkers/room.tsx | Passes timeoutSecs only on the local player’s turn; updates hints and placeholder sizing. |
| games/checkers/board.tsx | Allows switching selected piece mid-turn; updates board colors and adds movable-piece animations. |
| app/globals.css | Adds piece-nudge and action-pulse keyframes and utilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /> | ||
| ) : ( | ||
| <div className="aspect-square w-full max-w-[620px] animate-pulse rounded-xl bg-muted/50" /> | ||
| <div className="aspect-square w-full max-w-155 animate-pulse rounded-xl bg-muted/50" /> |
| /> | ||
| ) : ( | ||
| <div className="grid aspect-square w-full max-w-[560px] animate-pulse grid-cols-8 overflow-hidden rounded-xl"> | ||
| <div className="grid aspect-square w-full max-w-140 animate-pulse grid-cols-8 overflow-hidden rounded-xl"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.