feat: add AGENT documentation and implement GetDeveloperId component … - #8
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adds contributor-facing documentation (AGENT.md) and introduces a self-only “Get Developer ID” control on the user profile, alongside a couple of small UI and infrastructure/auth adjustments.
Changes:
- Add external “Docs” and “Telegram” links to the app footer and render external links with
<a target="_blank">. - Add
GetDeveloperIdclient component and surface it in the profile header for the signed-in profile owner. - Standardize cron auth to use
INTERNAL_API_SECRETand add AGENT.md repository guidance.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| components/shell/app-footer.tsx | Adds external footer links and tweaks container sizing. |
| components/profile/profile-header.tsx | Integrates GetDeveloperId into the profile header layout. |
| components/profile/get-developer-id.tsx | New client component for copying the developer/platform user ID. |
| app/api/cron/lobby-ttl/route.ts | Adjusts cron authorization secret selection. |
| AGENT.md | Adds agent/contributor guidance and architecture rules. |
Suppressed comments (2)
components/shell/app-footer.tsx:33
- External links opened with
target="_blank"should includerel="noopener noreferrer"to prevent reverse-tabnabbing. The codebase already usesnoopener noreferrerfor other external links.
href={link.href}
className="hover:text-foreground"
target="_blank"
rel="noreferrer"
>
components/profile/get-developer-id.tsx:120
- “Copy and close” will close the dialog even when copying fails because
copyId()catches errors and resolves, so the.then(() => setOpen(false))always runs. Consider returning a success boolean (or rethrowing on failure) so the dialog only closes on successful copy.
<Button
type="button"
variant="primary"
onClick={() => void copyId().then(() => setOpen(false))}
>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return ( | ||
| <footer className="mt-20 border-t border-border/60"> | ||
| <div className="mx-auto flex w-full max-w-[1400px] flex-col gap-6 px-4 py-10 sm:px-6 md:flex-row md:items-center md:justify-between lg:px-8"> | ||
| <div className="mx-auto flex w-full max-w-350 flex-col gap-6 px-4 py-10 sm:px-6 md:flex-row md:items-center md:justify-between lg:px-8"> |
| href="https://docs.stackswars.com/develop/contributing" | ||
| className="text-foreground underline underline-offset-2" | ||
| target="_blank" | ||
| rel="noreferrer" |
|
|
||
| function cronAuthorized(request: Request): boolean { | ||
| const secret = process.env.CRON_SECRET?.trim() || process.env.INTERNAL_API_SECRET?.trim() | ||
| const secret = process.env.INTERNAL_API_SECRET?.trim() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for user profile