feat: update environment configuration for local custodial mnemonic e… - #9
Merged
iflames1 merged 1 commit intoAug 1, 2026
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
iflames1
deleted the
feat/add-custodial-dev-secret-for-local-kms-encrytion
branch
August 1, 2026 22:58
There was a problem hiding this comment.
Pull request overview
Adds a local-development encryption option for custodial mnemonics by introducing CUSTODIAL_DEV_SECRET-based envelope encryption, while keeping Google Cloud KMS as the production mechanism.
Changes:
- Add AES-256-GCM encryption/decryption path gated by
CUSTODIAL_DEV_SECRET, with adev1:ciphertext prefix for local-only blobs. - Update local environment template to include
CUSTODIAL_DEV_SECRET. - Update README stack description to clarify local vs production custodial encryption configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Documents local (CUSTODIAL_DEV_SECRET) vs production (Google Cloud KMS) custodial wallet encryption. |
| lib/kms/envelope.ts | Implements dev-secret AES-GCM encryption fallback and a dev1: prefix to distinguish local ciphertexts from KMS ciphertexts. |
| env.example | Adds CUSTODIAL_DEV_SECRET for local mnemonic encryption configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
97
to
100
| throw new Error( | ||
| "Google Cloud KMS is required for custodial wallets. Set GOOGLE_CLOUD_PROJECT, KMS_KEY_RING, KMS_CRYPTO_KEY, and GOOGLE_SERVICE_ACCOUNT_KEY." | ||
| "Custodial wallet encryption is not configured. For local development set CUSTODIAL_DEV_SECRET (openssl rand -base64 32)." | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ncryption