Repository navigation
Fix: 4 issues (#884, #885, #886, #888) - #945
Open
Busiii-adetiba wants to merge 1 commit into
Open
Busiii-adetiba wants to merge 1 commit into
Busiii-adetiba wants to merge 1 commit into
Conversation
Co-authored-by: Simple Agent <agent@simple.dev>
|
@Busiii-adetiba is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Busiii-adetiba Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #884
Closes #885
Closes #886
Closes #888
Issues
#884 Implement WalletConnect v2 integration for mobile wallets
#885 Add wallet address validation and ENS/federation resolution
#886 Implement account balance display and monitoring
#888 Implement wallet connection persistence across sessions
Summary
Add @walletconnect/web3wallet, @walletconnect/core, and @walletconnect/utils dependencies and set NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID in env. The WalletConnect service must be browser-only and lazily initialized to avoid SSR/build issues. Persistence should use localStorage with an opt-out privacy flag; do not store secrets, only address and wallet type. Auto-reconnect must verify the stored address with the wallet before trusting it. Federation resolution should be cached with a TTL and must never throw to the UI. Balance polling should pause when the tab is hidden. All new hooks and components need unit tests, and CI (lint, typecheck, tests) must pass before review.
Changes