Repository navigation
Add perf benchmarking, a11y testing, snapshot testing, test data factories - #959
Open
chriz-cloud wants to merge 4 commits into
Open
chriz-cloud wants to merge 4 commits into
chriz-cloud wants to merge 4 commits into
Conversation
Collects Core Web Vitals (LCP, CLS, INP, FCP, TTFB) via PerformanceObserver, reports them to Sentry as measurements, flags budget regressions, and adds a Lighthouse CI workflow/config enforcing lab performance budgets on every PR.
…plit#905) Adds axe-core unit tests for shared components (StatusBadge, Skeleton) to complement the existing Playwright page-level WCAG gate, and documents the manual screen-reader/keyboard/contrast review process and findings workflow.
Adds Vitest snapshot tests for StatusBadge and Skeleton/SkeletonCard, a unit-tests CI workflow running vitest --ci, and docs covering the snapshot review process and how to avoid snapshot sprawl.
…split#907) Adds reusable factory functions (buildInvoice/buildPayment/buildUser) with sequence-based unique ids, override support, list builders, and lifecycle fixtures, plus tests proving the factories and documentation of the pattern.
|
@luhrhenz is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@chriz-cloud Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #904
Closes #905
Closes #906
Closes #907
Summary
src/lib/performanceMonitoring.ts, wired intoinstrumentation-client.ts, reported to Sentry as measurements with budget-regression warnings, plus a Lighthouse CI workflow (.github/workflows/performance.yml,lighthouserc.json) enforcing lab performance budgets on every PR. Seedocs/PERFORMANCE.md.e2e/a11y.spec.ts,.github/workflows/accessibility.yml). Added component-level axe-core unit tests (src/__tests__/a11y/componentA11y.test.tsx) for shared components, and documented the manual screen-reader/keyboard/contrast review process indocs/ACCESSIBILITY.md.StatusBadgeandSkeleton/SkeletonCard(src/__tests__/snapshots/), a newunit-tests.ymlCI workflow runningvitest run --ci, anddocs/SNAPSHOT_TESTING.mdcovering the review process and how to avoid snapshot sprawl. Note:.snapbaseline files will be generated on first CI/local run and should be committed in a follow-up once reviewed.src/test/factories/withbuildInvoice,buildPayment,buildUserfactory functions (override support, list builders, lifecycle fixtures), sequence-reset helpers to avoid cross-test pollution, tests proving the factories, and a README documenting the pattern and design tradeoffs.