Repository navigation
test(SC-002): upgrade storage integrity + proxy/impl storage-slot collision prevention - #1710
Open
esthertitilayo-dev wants to merge 1 commit into
Conversation
… storage-slot collisions (StellarDevHub#1623) - Add proxy state-persistence test covering admin, pending admin, registered wasm hashes, proposals, and storage version before/after execute_upgrade - Add storage-key collision test comparing XDR encodings of ProxyDataKey vs ImplDataKey and proving both key families coexist in contract storage - Add unauthorized register_wasm regression test - Add implementation_v2 test suite covering score/name storage isolation, pre-upgrade (V1) state readability, overflow saturation, and admin gating
|
@esthertitilayo-dev is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@esthertitilayo-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1623
Summary
proxy: addtest_proxy_state_persists_across_upgradeproving admin, pending-admin ceremony, registered wasm hashes, upgrade proposals, and storage version all surviveexecute_upgrade.proxy: addtest_proxy_and_impl_storage_keys_do_not_collidecomparing XDR encodings ofProxyDataKeyvsimplementation_v1::ImplDataKey(impl proxy keys intentionally alias proxy keys; app-state keys must not) plus a behavioral check that both key families coexist in the same contract storage without clobbering each other.proxy: addtest_unauthorized_register_wasmregression (admin-only bytecode registration, AC1).implementation_v2: new test suite (src/tests.rs) covering score/name storage isolation (additiveName(Address)key never disturbsScore(Address)), pre-upgrade V1 state readability (score written underimplementation_v1::ImplDataKey::Scoreis read back by V2), overflow saturation, and admin gating (#2).Test plan
cargo test -p proxy -p implementation_v1 -p implementation_v2— 16 + 3 + 8 tests pass (workspace-local toolchain).cargo fmt --checkclean on all touched files (repo has pre-existing fmt drift inproxy/src/security_council.rsand EOF ofproxy/src/tests.rs, untouched).