Repository navigation
Document payments summary endpoint and sync metadata/README architecture - #919
Merged
rasputin2525 merged 3 commits intoOct 21, 2026
Merged
Conversation
…kit … sdk, rpc, co Closes StellarGateLabs#867
…nd contradicts its Closes StellarGateLabs#868
…ments/summary`, an Closes StellarGateLabs#869
|
@ubermensh-323 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document payments summary endpoint and sync metadata/README architecture
What was solved
#867 —
Cargo.tomlmetadata describes a "Rust toolkit … sdk, rpc, command-line-utilities" — it's a payment-gateway serverUpdate the crate metadata in Cargo.toml to accurately describe StellarGate as a non-custodial payment-gateway API (description, keywords, categories, homepage, readme), and align the OCI image description label in the Dockerfile with the same one-line description.
Addressed:
descriptionto "Non-custodial payment gateway API for accepting and settling payments on the Stellar network"keywordswith ["stellar", "payments", "payment-gateway", "webhooks", "xlm"]categorieswith ["web-programming::http-server", "finance"] (valid crates.io slugs)#868 — README architecture section is out of date and contradicts itself about
migrations/Update the README architecture section so its tree matches the actual repository: remove the nonexistent
migrations/entry (replacing it with a pointer todb::migrate/MIGRATIONS.md), add the missing source/asset directories and files (src/audit.rs,src/supervise.rs,src/bin/audit_undercredit.rs,examples/dump_schema.rs,static/*.jsmodules,e2e/,scripts/,deploy/), and clarify that new modules need routes and that schema lives indb::migrate. Optionally extendscripts/check-deploy-consistency.shto verify README-listed paths exist.Addressed:
migrations/line with a pointer todb::migrateandMIGRATIONS.mdsrc/audit.rs,src/supervise.rs,src/bin/audit_undercredit.rs,examples/dump_schema.rs,static/*.jsmodules,e2e/,scripts/,deploy/#869 —
openapi.yamldoesn't documentGET /v1/payments/summary, and the drift tests don't noticeDocument the authenticated
GET /v1/payments/summaryendpoint inopenapi.yaml(security, query params, response schema with per-status counts and per-asset totals as canonical strings, and 401/400/429 error responses), and make drift detection bidirectional by adding a router→spec test that enumerates the router's served(method, path)entries and asserts each appears in the spec (or is explicitly marked internal).Addressed:
GET /v1/payments/summaryinopenapi.yamlwithbearerAuthsecurity, query params matching whatpayments::summaryaccepts (e.g. date range), response schema (per-status counts and per-asset totals, amounts as canonical strings perto_jsonconventions), and 401/400/429 responses using the shared error schema.(method, path)the router serves, used both to build the router and in a test asserting every entry appears inopenapi.yaml(or is explicitly marked internal, like dashboard assets)./payments/summaryif the legacy mount exposes it, documenting theDeprecationheader like other legacy paths.Changes
scripts/check-deploy-consistency.sh(modify)Dockerfile(modify)Cargo.toml(modify)tests/openapi_drift_tests.rs(modify)Approach
Cargo.tomlmetadata describes a "Rust toolkit … sdk, rpc, command-line-utilities" — it's a payment-gateway server #867 —Cargo.tomlmetadata describes a "Rust toolkit … sdk, rpc, command-line-utilities" — it's a payment-gateway server (Changed: Cargo.toml, Dockerfile)migrations/#868 — README architecture section is out of date and contradicts itself aboutmigrations/(Changed: scripts/check-deploy-consistency.sh)openapi.yamldoesn't documentGET /v1/payments/summary, and the drift tests don't notice #869 —openapi.yamldoesn't documentGET /v1/payments/summary, and the drift tests don't notice (Changed: tests/openapi_drift_tests.rs)Issues
Closes #867
Closes #868
Closes #869