Skip to content

refactor(auth): optimize auth service with caching and concurrency #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TS-mfon merged 5 commits into from
Oct 17, 2026
Merged

refactor(auth): optimize auth service with caching and concurrency #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
096f6f5
refactor(auth): optimize auth service with caching and concurrency
dee-john Oct 16, 2026
602a5fb
Merge branch 'dev' into feat/auth-service-optimization
dee-john Oct 17, 2026
a9ef04e
fix: resolve TypeScript compilation and lint errors from upstream merge
dee-john Oct 17, 2026
4a4d9df
fix(tests): resolve SQLite entity metadata and token generation for i…
dee-john Oct 17, 2026
e6f636e
Merge branch 'dev' into feat/auth-service-optimization
dee-john Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/middleware/auth.middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,20 +355,23 @@ export function requireSeller() {
};
}

export function requireAdmin(adminWallets: string[]) {
export function requireAdmin(adminWallets: string[] = []) {
return (req: Request, _res: Response, next: NextFunction): void => {
const user = (req as AuthenticatedRequest).user;
if (!user) {
next(new HttpError(401, "Authentication required"));
return;
}

if (!adminWallets.includes(user.stellarAddress)) {
next(new AppError(403, "Admin privileges required", "ADMIN_REQUIRED"));
if (
user.userType === UserType.ADMIN ||
(adminWallets.length > 0 && adminWallets.includes(user.stellarAddress))
) {
next();
return;
}

next();
next(new AppError(403, "Admin privileges required", "ADMIN_REQUIRED"));
};
}

Expand Down
7 changes: 4 additions & 3 deletions src/routes/accreditation.routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function createAccreditationRouter({
auth,
async (req: WalletParamsRequest, res: Response, next: NextFunction) => {
try {
const { wallet } = req.params;
const wallet = String(req.params.wallet);
const accreditation = await accreditationService.getAccreditation(wallet);

res.json({
Expand All @@ -54,7 +54,7 @@ export function createAccreditationRouter({
requireAdmin(adminWallets),
async (req: WalletParamsRequest, res: Response, next: NextFunction) => {
try {
const { wallet } = req.params;
const wallet = String(req.params.wallet);
const { tier, verificationSource } = req.body;

if (!Object.values(AccreditationTier).includes(tier)) {
Expand Down Expand Up @@ -84,7 +84,8 @@ export function createAccreditationRouter({
auth,
async (req: WalletEligibilityParamsRequest, res: Response, next: NextFunction) => {
try {
const { wallet, invoiceId } = req.params;
const wallet = String(req.params.wallet);
const invoiceId = String(req.params.invoiceId);
const eligibility = await accreditationService.checkEligibility(
wallet,
invoiceId
Expand Down
2 changes: 1 addition & 1 deletion src/routes/secondary-market/price-history.routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function createPriceHistoryRouter({
auth,
async (req: InvoicePriceHistoryRequest, res: Response, next: NextFunction) => {
try {
const { invoiceId } = req.params;
const invoiceId = String(req.params.invoiceId);
const range = (req.query.range as PriceRange) || "30d";

if (!["7d", "30d", "all"].includes(range)) {
Expand Down
Loading
Loading