Repository navigation
Conversation
…mestamp - Auto-invest: Use actual available invoice capacity (amount - invested) instead of netAmount (discounted amount) to correctly determine investment capacity - Analytics: Use invoice.updatedAt instead of latest investment createdAt for more accurate funding completion timestamp Closes StellarState#596 Closes StellarState#587
- Add PATCH /auto-invest/rules/:ruleId endpoint to update rule criteria or toggle enabled status - Add comprehensive input validation for all numeric fields - Support partial updates without requiring all fields - Maintain ownership validation for rule modifications Completes issue StellarState#596
Contributor
Author
|
Closing — PR should target dev, not main. Reopening with correct base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive fixes and enhancements for the auto-invest rule engine and issuer analytics features:
🐛 Critical Bugs Fixed
Auto-Invest Investment Capacity Bug (#596)
invoice.netAmount(discounted amount) to calculate available investment capacityinvoice.amount - total_invested, then cap byrule.maxPerInvoiceAnalytics Funding Timestamp Bug (#587)
invoice.updatedAtwhen invoice status is FUNDED/SETTLED (the actual status change time)✨ Feature Enhancements
Complete Auto-Invest Rule CRUD (#596)
/api/v1/auto-invest/rules/:ruleIdendpoint to update rule criteriaenabledstatus without deleting/recreating rulesImplementation Status
Closes #596
Closes #587
Closes #589
Closes #588