Repository navigation
test(events): add boundary spec cases for royaltyBps and maxResaleMultiplierBps - #464
Merged
EmmanuelOchaje merged 1 commit intoOct 18, 2026
Conversation
…tiplierBps (StellarTickets#97) Covers @min(0) and @max boundaries for both fields — negative values, exact-minimum, exact-maximum, and above-maximum — along with non-integer rejection to complete the DTO's validation surface. Closes StellarTickets#93 Closes StellarTickets#95 Closes StellarTickets#97 Closes StellarTickets#99
|
@opascal221-design Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for stellarticketsbackend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
Closes #95
Closes #97
Closes #99
Adds a
describe('royaltyBps and maxResaleMultiplierBps (#97)')block tocreate-event.dto.spec.tscovering all missing boundary cases for both fields:royaltyBps: accepts0(min boundary), accepts2000(max boundary), rejects-1(below min), rejects1.5(non-integer)maxResaleMultiplierBps: accepts10000(min boundary, exactly 100%), accepts50000(max boundary), rejects50001(above max), rejects10000.5(non-integer)These tests exercise the existing
@Min/@Max/@IsIntvalidators that guard the contract's royalty and resale-cap fields before any chain call is attempted.