Repository navigation
Open a Camera's SIMULATED picture from its Sensor row in the Sandbox - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
In the Sandbox, the Readings Panel's "Camera: Picture N" line opens that Sensor's newest picture through an
<img>, marked SIMULATED beside it (the drawing holds the word too), with "Stays on this Camera; it does not cross the Mesh". The URL carries the picture number, so it refetches when the number changes. Outside the Sandbox only the connected Node's own Camera opens (/api/camera/picture).Tested:
scripts/check.sh dashboardall pass (516 tests), new flow testcameraPictureFlow.test.tsxcovers open, refresh, close and the non-Sandbox case. Not checked on a real phone; phone width relies on a full-width image and 2.5rem tap target. code-review run on StormShields/Stormshield against origin/main; no hard standards violations.