Repository navigation
Open the Sandbox app: file locations, free port, failure page (#118) - #129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
app_files.py: one place for where the dashboard, Regions and Cache Packs live (checkout or bundle);scripts/sandbox.shandstorm-shield-sandboxunchanged in behaviour (the browser URL is now127.0.0.1).storm-shield-sandbox-app: no arguments. Opens a Sandbox already on 8000, else serves on 8000 or a free port; logs tostorm-shield-sandbox.login the temp folder; any start failure (including uvicorn failing to bind) opens a page with the error and the log path.127.0.0.1only (sandbox_server_config, tested).Tested: node mypy, ruff, and the full node pytest passed before the final merge of
main. Sandbox, region and app tests rerun after the review fixes (75 passed). Dashboard untouched; its checks not run here (nonode_modules). Not exercised on a real double-click or a bundled app (packaging is the next slice).Review notes:
serve()itself isn't tested for using the loopback config (it needs a full Sandbox start); the second-start check only looks at port 8000.