Repository navigation
Stop the Sandbox app from its panel, and end it after ten idle minutes (#119) - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
What
app=True) servesPOST /api/sandbox/stop;/api/state'ssandbox.can_stoptells the Panel to show Stop Sandbox. Outside the app the route doesn't exist andcan_stopis false.Hostthat isn't a loopback name (DNS rebinding), and anOriginthat isn't the page's own. A request with noOriginis allowed: browsers always send one on a cross-site POST, so only a local non-browser process can omit it./api/staterequest (Sandboxclock; tests use a fake clock and a short limit). Both paths set the server to exit, so thewithremoves the temp folder.Tested
scripts/check.shpasses. Realserve()runs end on Stop and on idle with the folder gone. Not tested: a real Windows/macOS double-click (no app bundle in this slice).Security review
Requested: a route that ends the process.