Repository navigation
Build the Mac and Windows Sandbox downloads in CI and publish a Release - #131
Merged
Merged
Conversation
…publish a Release by dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
What
scripts/sandbox_app_build.py: PyInstaller one-folder build, zipped (.appon Apple Silicon, windowed.exeon Windows x64). Holds Python, the Node package, the built dashboard,regions/and both Regions' published Cache Packs. Nothing else of the checkout goes in.scripts/sandbox_app_smoke.py: starts the zipped app with the browser stubbed and checks no.envis inside, both packs are,/api/statereports asandbox, the Sandbox has Sensors, a Region switch works on the bundled pack (no download), Stop ends the process, and the temp folder is gone..github/workflows/sandbox-app.yml: build + smoke on macOS-14 and Windows-2022 for PRs touching the packaging; manual dispatch with a number also publishessandbox-app-v<N>(not latest, frommainonly).scripts/check.shis untouched.scripts/sandbox-app-release-notes.md.Call worth a look: Nepal pack v2
The smoke check found that the bundled Nepal pack (Release
cache-pack-nepal-v1) predateshub_site, so switching to Nepal returned a 500. This also hits a checkout with no local pack. I rebuilt it from the currentregions/nepal/region.json(scripts/build-cache-pack.sh nepal), publishedcache-pack-nepal-v2(not latest) and bumpedRELEASED_PACKS.Tested
scripts/check.sh: all pass.After merge
Dispatch the workflow with version
1to publishsandbox-app-v1; the ticket isn't finished until it exists. Security review requested (public binary download).code-reviewreviewed this repo (StormShields/Stormshield) againstorigin/main.