Repository navigation
The Node's English counts in words, and Matters says what you can see - #331
Merged
Merged
Conversation
Every "(s)"/"(es)" in the Worker's, the CLI's and the Butler compiler's own
sentences becomes a real plural through one helper, plural(n, one, other) in
@mailda/runtime, with verbs agreeing ("1 message has", "1 person holds").
Codes, check names, log events and fields are unchanged. The interface catalog
had none left. docs/history.md lists every changed sentence for agents.
Matters' empty state said "No matters have been opened." to a member whose
list the Node filters to the ones they opened. It now says "No matters you can
see" with the rule (en, zh-Hans 事项), and a route test holds the filtering.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # apps/node/worker/src/doctor/butlers.ts # apps/node/worker/src/i18n/en/matters.ts # apps/node/worker/src/i18n/zh-Hans/matters.ts # apps/node/worker/src/routes/session.ts # docs/history.md # docs/i18n.md
#330 added a refused-read test and golden expecting "No matters have been opened."; this branch changed that sentence to "No matters you can see…", so both follow it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two follow-ups.
plural(n, one, other)in@mailda/runtime, with agreeing verbs ("1 message has", "1 person holds"). About 120 sentences; every code, check name, log event and field unchanged; docs/history.md lists each changed sentence for agents.Verified on the merged branch: typecheck, lint, workerd 2,202, node 885, DOM 868.
🤖 Generated with Claude Code