Repository navigation
A failed notification log write turns a successful application action into a 500 #282
Description
Summary
The application create and review routes await notify(...) after the row
is committed, with no try/catch. If the notification log write fails the
client gets a 500 even though the application was created or reviewed, and
retrying then returns 409.
Acceptance criteria
- Catch and log notification errors in those routes and return the normal success response.
- Add a test where
notifythrows and the route still returns 201 / 200.
Getting started
Fork this repository, clone your fork, and add this repo as upstream:
git clone https://github.com/<your-username>/streamgive-backend.git
cd streamgive-backend
git remote add upstream https://github.com/StreamGive/streamgive-backend.gitCreate a branch for this issue:
git checkout -b fix/application-notify-errorsSuggested commit message:
fix(applications): don't fail the request when notifying fails
Run npm run lint, npm run typecheck, and npm test before pushing, then
open a pull request from your fork against main and link this issue. See
the contributing guide for the full contribution guide.
Activity
charliechinedu19-netizen commentedon Oct 18, 2026
@charliechinedu19-netizen has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @charliechinedu19-netizen to this issue.
sweetgirl8523 commentedon Oct 18, 2026
@sweetgirl8523 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @sweetgirl8523 to this issue.
AMDYFX commentedon Oct 18, 2026
@AMDYFX has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @AMDYFX to this issue.
drips-wave commentedon Oct 18, 2026
Congratulations, @AMDYFX! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @AMDYFX: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
github-actions commentedon Oct 18, 2026
Closed by #340, which was merged automatically.
drips-wave commentedon Oct 18, 2026
This issue has been completed by @AMDYFX as part of the Stellar Wave Program's 10th Wave 🥳
😎 @AMDYFX: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.