Repository navigation
fix(validation): verify Stellar address checksums - #329
Closed
mikemikimike wants to merge 2 commits into
Closed
mikemikimike wants to merge 2 commits into
mikemikimike wants to merge 2 commits into
Conversation
Contributor
|
Not auto-merged: @mikemikimike is not assigned to #277. The PR may only close issues you are assigned to. Ask to be assigned, or remove the closing reference. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StrKey.isValidEd25519PublicKeyfor donor lookups, NGO lookup, stream filters, and NGO application submission and status.Closes #277
#277
Validation
main(f59f86cf009d9c98520e8037125e52611da0f415) with merge commit0fcedff4702c9fc31d422b07b77b54301799188e. The merge resolves conflicts insrc/routes/donors.tsandsrc/routes/ngos.ts, preserving checksum validation and current NGO display-name handling.git diff --checkpassed.npm teston clean currentmain: 177 passed, 46 failed. On the updated PR head: 179 passed, 46 failed, with the exact same 46 failing test names as the clean base.donors,ngoApplications, andstreams) had 46 passed and 16 failed on the clean base; the updated head had 48 passed and 16 failed with the same failure set.npm run lintreports 10 existing findings insrc/admin/dto/admin-ngos.controller.spec.ts,src/health/health.controller.ts,src/index.ts, andtest/shutdown.integration.spec.ts. Targeted ESLint on all changed files passes.npm run typecheckandnpm run buildfail on the clean base and updated head with the same existing parse error atsrc/index.ts:111(TS1128).CIrun for the updated head concludedaction_requiredbefore starting any jobs (0 jobs). Theauto-mergecheck passed.