Repository navigation
Feat/multi 274 287 285 270 - #320
Merged
github-actions[bot] merged 4 commits intoOct 17, 2026
Merged
github-actions[bot] merged 4 commits into
github-actions[bot] merged 4 commits into
Conversation
|
@Feyisara2108 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR implements issues #274, #287, #285, and #270 across
ngo-registry,donation-vault, and the deployment scripts:is_verified(owner) -> boolonNgoRegistry, delegating toget_ngoto maintain single-source-of-truth verification semantics without panicking or erroring on unknown addresses. Adds unit test coverage across verified, unverified, revoked, and unknown addresses.set_registry,registry(), andcreate_streamverification using the realNgoRegistrycontract indonation-vaulttest suite. Tests verified, unverified, unregistered, and revoked NGOs, along with non-admin rejection and behavior when no registry is configured.withdraw_batchindonation-vault, covering multi-stream batches with fee accounting,Error::MixedNgorejection, zero-accrual stream skipping, multi-token fee aggregation (global fee vs. per-token override), NGO authorization enforcement, empty batches, unknown streams (Error::StreamNotFound), and cancelled streams.deploy-testnet.shanddeploy-mainnet.shto support optional post-init vault configuration via environment variables (STELLAR_REGISTRY_ADDRESS,STELLAR_TREASURY_ADDRESS,STELLAR_FEE_BPS,STELLAR_MIN_DEPOSIT), validates inputs before invocation, verifiesadmin()equals the intended admin, prints read-back configuration fromget_configandregistry(), and enforces registry opt-in requirements on mainnet.Closes #274
Closes #287
Closes #285
Closes #270