Skip to content

Feat/multi 274 287 285 270 - #320

Merged
github-actions[bot] merged 4 commits into
StreamGive:mainfrom
Feyisara2108:feat/multi-274-287-285-270
Oct 17, 2026
Merged

github-actions[bot] merged 4 commits into
StreamGive:mainfrom
Feyisara2108:feat/multi-274-287-285-270

Conversation

@Feyisara2108

Copy link
Copy Markdown
Contributor

Summary of Changes

This PR implements issues #274, #287, #285, and #270 across ngo-registry, donation-vault, and the deployment scripts:

  1. Issue is_verified is missing from the registry on main #274: Restores is_verified(owner) -> bool on NgoRegistry, delegating to get_ngo to maintain single-source-of-truth verification semantics without panicking or erroring on unknown addresses. Adds unit test coverage across verified, unverified, revoked, and unknown addresses.
  2. Issue Add tests for set_registry and the NgoNotVerified path #287: Adds comprehensive cross-contract tests for set_registry, registry(), and create_stream verification using the real NgoRegistry contract in donation-vault test suite. Tests verified, unverified, unregistered, and revoked NGOs, along with non-admin rejection and behavior when no registry is configured.
  3. Issue Add tests for withdraw_batch #285: Adds comprehensive unit tests for withdraw_batch in donation-vault, covering multi-stream batches with fee accounting, Error::MixedNgo rejection, zero-accrual stream skipping, multi-token fee aggregation (global fee vs. per-token override), NGO authorization enforcement, empty batches, unknown streams (Error::StreamNotFound), and cancelled streams.
  4. Issue The deploy scripts never configure the vault after initialising it #270: Updates both deploy-testnet.sh and deploy-mainnet.sh to support optional post-init vault configuration via environment variables (STELLAR_REGISTRY_ADDRESS, STELLAR_TREASURY_ADDRESS, STELLAR_FEE_BPS, STELLAR_MIN_DEPOSIT), validates inputs before invocation, verifies admin() equals the intended admin, prints read-back configuration from get_config and registry(), and enforces registry opt-in requirements on mainnet.

Closes #274
Closes #287
Closes #285
Closes #270

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@Feyisara2108 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant