Repository navigation
feat(donate): add a Max button with a fee reserve - #285
Merged
github-actions[bot] merged 1 commit intoOct 18, 2026
Merged
Conversation
|
@Favourof is attempting to deploy a commit to the Ashborne team Team on Vercel. A member of the Team first needs to authorize it. |
|
@Favourof Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #237.
The donation form previously lacked a "Max" button. Additionally, the insufficient balance validation did not account for the native XLM network fee or minimum base account reserve. If a donor tried to stream their entire XLM balance, the frontend check would pass but the transaction would fail on-chain during signing/submission.
This PR introduces a "Max" quick-fill button and reserves a safe balance buffer for native XLM transactions.
Changes
src/lib/stellar.ts:NATIVE_ACCOUNT_RESERVE = 10_000_000n(1.0 XLM).NATIVE_FEE_ESTIMATE = 1_000_000n(0.1 XLM).NATIVE_FEE_RESERVE = 11_000_000n(1.1 XLM buffer).src/lib/format.ts:formatAmountInput(raw: bigint, decimals: number).src/components/donate/CreateStreamForm.tsx:NATIVE_FEE_RESERVEso the account retains necessary reserve and fee funds.balance - NATIVE_FEE_RESERVEare warned about insufficient reserve buffer before signing.src/lib/format.test.ts: Added unit tests forformatAmountInput.src/components/donate/CreateStreamForm.test.tsx: Added tests for native fee reserve deduction, non-native token max balance, and boundary conditions.How to Test
npx vitest run src/components/donate/CreateStreamForm.test.tsx src/lib/format.test.ts.