Repository navigation
JVNAUTOSCI-2592: retry bounded KR read-back timeouts - #302
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Atlas-variance read-back timeouts in the KR materialisation workflow by adding a tightly bounded retry policy to the KR read-back steps, and then propagates the resulting seed-version/fingerprint updates through the spreadsheet programme seed bundle and associated tests.
Changes:
- Bump KR materialisation repo seed bundle from v5 → v6 and add a fixed 1s, max-2-attempts retry policy to
read_back_conceptandread_back_text_relations(retrying only thefailureoutcome). - Bump spreadsheet programme workflow seed bundle from v18 → v19 to record the updated KR dependency identity and refreshed processing-authority fingerprint.
- Update backend tests to assert the new seed versions and the new retry policy payload in the KR seed.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/backend/test_spreadsheet_programme_workflow_vontology_service.py | Updates expected spreadsheet seed version and KR dependency seed version. |
| tests/backend/test_kr_materialisation_workflow_vontology_service.py | Asserts KR seed version bump and validates the new read-back retry policy in the seed payload. |
| src/backend/workflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json | Updates seed version, KR dependency identity, and processing-authority fingerprint to match regenerated bundle. |
| src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json | Bumps seed version and adds bounded retry policies to KR read-back steps. |
| scripts/generate_spreadsheet_programme_workflow_seed.py | Bumps generated spreadsheet seed bundle version to v19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live failure
The corrected description mapping completed three reuse items. A fourth item then failed safely when read-only
fetch_conceptexceeded its 20-second hard deadline under Atlas variance. No write had an unknown outcome; fail-fast left six items unattempted.Fix
read_back_conceptandread_back_text_relationsfailureoutcomesha256:7ecf13bbdfa9a9a95f28eefc3634fad91cc5c7498aa0aa84b6763ab965c46267Validation