Skip to content

JVNAUTOSCI-2592: retry bounded KR read-back timeouts - #302

Merged
witbrock merged 1 commit into
mainfrom
jvnautosci-2592-readback-retry
Jul 24, 2026
Merged

witbrock merged 1 commit into
mainfrom
jvnautosci-2592-readback-retry

Conversation

@witbrock

Copy link
Copy Markdown
Member

Live failure

The corrected description mapping completed three reuse items. A fourth item then failed safely when read-only fetch_concept exceeded its 20-second hard deadline under Atlas variance. No write had an unknown outcome; fail-fast left six items unattempted.

Fix

  • add one fixed 1-second retry to read_back_concept and read_back_text_relations
  • retry only the represented failure outcome
  • do not retry create, relationship writes, description writes, or unknown outcomes
  • bump KR seed to v6 and regenerate spreadsheet seed v19 with fingerprint sha256:7ecf13bbdfa9a9a95f28eefc3634fad91cc5c7498aa0aa84b6763ab965c46267

Validation

  • 15 focused tests pass
  • KR workflow contracts and seed-version checks pass
  • generator, Ruff, formatting, and diff checks pass

Copilot AI review requested due to automatic review settings July 24, 2026 05:27
@witbrock
witbrock marked this pull request as ready for review July 24, 2026 05:27
@witbrock
witbrock merged commit c5fd552 into main Jul 24, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Atlas-variance read-back timeouts in the KR materialisation workflow by adding a tightly bounded retry policy to the KR read-back steps, and then propagates the resulting seed-version/fingerprint updates through the spreadsheet programme seed bundle and associated tests.

Changes:

  • Bump KR materialisation repo seed bundle from v5 → v6 and add a fixed 1s, max-2-attempts retry policy to read_back_concept and read_back_text_relations (retrying only the failure outcome).
  • Bump spreadsheet programme workflow seed bundle from v18 → v19 to record the updated KR dependency identity and refreshed processing-authority fingerprint.
  • Update backend tests to assert the new seed versions and the new retry policy payload in the KR seed.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/backend/test_spreadsheet_programme_workflow_vontology_service.py Updates expected spreadsheet seed version and KR dependency seed version.
tests/backend/test_kr_materialisation_workflow_vontology_service.py Asserts KR seed version bump and validates the new read-back retry policy in the seed payload.
src/backend/workflows/repo_seed_bundles/spreadsheet_programme_representation_workflow_seed_bundle.json Updates seed version, KR dependency identity, and processing-authority fingerprint to match regenerated bundle.
src/backend/workflows/repo_seed_bundles/kr_materialisation_workflow_seed_bundle.json Bumps seed version and adds bounded retry policies to KR read-back steps.
scripts/generate_spreadsheet_programme_workflow_seed.py Bumps generated spreadsheet seed bundle version to v19.

@witbrock
witbrock deleted the jvnautosci-2592-readback-retry branch July 28, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants