Repository navigation
Merge outstanding backup hardening and workflow affordance fixes - #319
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request consolidates previously unmerged production hardening for backup/restore and restores JVNAUTOSCI-2608 workflow affordances by exposing represented workflows (and improved relationship predicate handling) through the generic adaptive-turn capability path.
Changes:
- Harden
run.shscheduled backup execution with lock-based concurrency control and validated “success evidence” receipts. - Keep MongoDB backup/restore credentials out of process arguments by switching
mongodump/mongorestoreto--configfiles with bounded timeouts. - Add represented-workflow discovery/execution as turn-scoped capabilities, plus typed predicate resolution/recovery affordances for
add_relationship.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_run_sh_start_behaviour.py | Adds extensive coverage for .env loading, scheduled-backup locking, and receipt validation/repair behaviours in run.sh. |
| tests/test_restore_von_db.py | Verifies mongorestore uses private config files and bounded timeouts without leaking URI credentials into tracebacks. |
| tests/test_backup_von_db.py | Verifies mongodump bounded timeouts and that URI credentials are not exposed in tracebacks. |
| tests/backend/test_workflow_turn_capability_service.py | New unit tests for represented workflow discovery, server-side binding, and receipt normalisation. |
| tests/backend/test_von_generate_workflow_instances.py | Ensures /von/generate forwards authorised workflow_inputs into the adaptive-turn path. |
| tests/backend/test_internal_mcp_add_relationship_predicate_validation.py | Updates/extends tests for typed predicate resolution, ambiguity handling, and typed recovery affordances. |
| tests/backend/test_adaptive_turn_service.py | Adds end-to-end adaptive-turn tests for discovering/invoking represented workflows and suppressing repeated terminal failures. |
| src/backend/services/workflow_turn_capability_service.py | New service providing turn-scoped represented workflow capability discovery, argument binding, and effect receipt normalisation. |
| src/backend/services/adaptive_turn_service.py | Integrates represented workflow discovery/execution into capability tooling; adds effect de-duplication/suppression after terminal failures. |
| src/backend/server/routes/von_routes.py | Passes workflow_launch_inputs into execute_adaptive_turn from the request path. |
| src/backend/integrations/internal_mcp/catalogue.py | Enhances add_relationship to resolve predicate names, support predicate_ref, and return typed recovery affordances. |
| scripts/restore_von_db.py | Switches to --config (no --uri in argv) and adds bounded timeout/error handling for mongorestore. |
| scripts/backup_von_db.py | Switches to --config (no --uri in argv) and adds bounded timeout/error handling for mongodump. |
| run.sh | Moves safe .env loading earlier; adds scheduled-backup action with receipt validation/repair and concurrency-safe locking. |
Comment on lines
+3339
to
+3343
| effect_request_signature = ( | ||
| _effect_request_signature(canonical_name, arguments) | ||
| if is_effect | ||
| else None | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Merge the outstanding production-ready changes that were present locally/remotely but not yet reachable from
origin/main:The branch is based on current
origin/main. It deliberately excludes:origin/mainin the newer, stricter5335e2c2implementation.Authority and scope
The 2608 change restores general represented-workflow affordances rather than adding arXiv- or paper-specific routing. Durable workflow meaning remains represented; Python supplies discovery, validation, bounded tool exposure, and execution support.
Validation
run.shbehaviour;zsh -n run.shpassed.git diff --check origin/main...HEADpassed.