Skip to content

Merge outstanding backup hardening and workflow affordance fixes - #319

Merged
witbrock merged 4 commits into
mainfrom
agent/merge-outstanding-20260728
Jul 28, 2026
Merged

witbrock merged 4 commits into
mainfrom
agent/merge-outstanding-20260728

Conversation

@witbrock

Copy link
Copy Markdown
Member

Outcome

Merge the outstanding production-ready changes that were present locally/remotely but not yet reachable from origin/main:

  • harden POSIX scheduled backup handling;
  • keep Mongo backup and restore credentials out of process arguments;
  • complete JVNAUTOSCI-2608 by exposing represented workflow capabilities and bounded relationship-predicate affordances through the generic adaptive-turn path.

The branch is based on current origin/main. It deliberately excludes:

  • experimental draft PR stacks that explicitly say not to merge;
  • the dirty active JVNAUTOSCI-2502 worktree;
  • the stale JVNAUTOSCI-2592 cardinality commit, whose intended capability is already present on origin/main in the newer, stricter 5335e2c2 implementation.

Authority and scope

The 2608 change restores general represented-workflow affordances rather than adding arXiv- or paper-specific routing. Durable workflow meaning remains represented; Python supplies discovery, validation, bounded tool exposure, and execution support.

Validation

  • 169 focused tests passed:
    • backup/restore and run.sh behaviour;
    • workflow-turn capability discovery;
    • relationship predicate validation;
    • adaptive-turn behaviour;
    • ordinary workflow generation path.
  • Ruff passed for all changed Python files.
  • zsh -n run.sh passed.
  • Changed production Python files byte-compiled successfully.
  • git diff --check origin/main...HEAD passed.
  • Consolidated tree matches the previously published JVNAUTOSCI-2608 branch exactly.

Copilot AI review requested due to automatic review settings July 28, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request consolidates previously unmerged production hardening for backup/restore and restores JVNAUTOSCI-2608 workflow affordances by exposing represented workflows (and improved relationship predicate handling) through the generic adaptive-turn capability path.

Changes:

  • Harden run.sh scheduled backup execution with lock-based concurrency control and validated “success evidence” receipts.
  • Keep MongoDB backup/restore credentials out of process arguments by switching mongodump/mongorestore to --config files with bounded timeouts.
  • Add represented-workflow discovery/execution as turn-scoped capabilities, plus typed predicate resolution/recovery affordances for add_relationship.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_run_sh_start_behaviour.py Adds extensive coverage for .env loading, scheduled-backup locking, and receipt validation/repair behaviours in run.sh.
tests/test_restore_von_db.py Verifies mongorestore uses private config files and bounded timeouts without leaking URI credentials into tracebacks.
tests/test_backup_von_db.py Verifies mongodump bounded timeouts and that URI credentials are not exposed in tracebacks.
tests/backend/test_workflow_turn_capability_service.py New unit tests for represented workflow discovery, server-side binding, and receipt normalisation.
tests/backend/test_von_generate_workflow_instances.py Ensures /von/generate forwards authorised workflow_inputs into the adaptive-turn path.
tests/backend/test_internal_mcp_add_relationship_predicate_validation.py Updates/extends tests for typed predicate resolution, ambiguity handling, and typed recovery affordances.
tests/backend/test_adaptive_turn_service.py Adds end-to-end adaptive-turn tests for discovering/invoking represented workflows and suppressing repeated terminal failures.
src/backend/services/workflow_turn_capability_service.py New service providing turn-scoped represented workflow capability discovery, argument binding, and effect receipt normalisation.
src/backend/services/adaptive_turn_service.py Integrates represented workflow discovery/execution into capability tooling; adds effect de-duplication/suppression after terminal failures.
src/backend/server/routes/von_routes.py Passes workflow_launch_inputs into execute_adaptive_turn from the request path.
src/backend/integrations/internal_mcp/catalogue.py Enhances add_relationship to resolve predicate names, support predicate_ref, and return typed recovery affordances.
scripts/restore_von_db.py Switches to --config (no --uri in argv) and adds bounded timeout/error handling for mongorestore.
scripts/backup_von_db.py Switches to --config (no --uri in argv) and adds bounded timeout/error handling for mongodump.
run.sh Moves safe .env loading earlier; adds scheduled-backup action with receipt validation/repair and concurrency-safe locking.

Comment on lines +3339 to +3343
effect_request_signature = (
_effect_request_signature(canonical_name, arguments)
if is_effect
else None
)
@witbrock
witbrock merged commit 9e59bc2 into main Jul 28, 2026
5 checks passed
@witbrock
witbrock deleted the agent/merge-outstanding-20260728 branch July 28, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants