Repository navigation
Preserve Unicode attachment metadata on S3 uploads (JVNAUTOSCI-2737) - #607
Merged
Merged
Conversation
witbrock
deleted the
task/JVNAUTOSCI-2737-unicode-attachment-metadata
branch
September 11, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 rejected native Jira attachment uploads when original filenames contained curly quotes or en dashes. The bytes remained in retained Jira originals, but the native task attachments lacked file bindings.
Encode non-ASCII metadata values as RFC 2047 on the S3 transport boundary, following S3's metadata contract. Preserve the exact original values in canonical file metadata and the returned BlobRef. The shared path covers byte and streamed-file uploads; ASCII values and existing key normalisation are unchanged.
Validation: 37 targeted blob-store and file-ingestion tests passed, including real Botocore metadata validation, Unicode round-trip and long-value coverage. No new Ruff findings. Both affected live attachments were recovered from retained originals; canonical read-back preserved native attachment identities and matched the original source SHA-256 values with Jira credentials disabled. Captured source data and audit artefacts are outside Git.
Merge decision: ready, subject to required CI. This repairs the observed upload failure; estate import, source reconciliation, paired restore and project writer cutover remain in progress under JVNAUTOSCI-2737.