Repository navigation
Place desktop composer controls beside the draft - #628
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — desktop users can type and reach send, microphone and a compact More actions disclosure in one composer row; Tier 1 checks support the change.
User outcome
Move the controls beside the desktop draft instead of reserving a separate row. Native task: #V#task_agent_3808f06e4d23b522e46f58e74b101160.
Material changes
Use a two-column desktop composer, including the runtime prompt overlay wrapper. Keep 44-pixel controls and the accessible More actions name; open secondary actions above the composer without expanding it. Attachment and speech status remain full width. Preserve the existing stacked layout on narrow screens and touch devices, using the conversation tray's desktop distinction. No send, speech or tray controller changes.
Evidence
node tests/browser/composerControls.cjs /tmp/von-composer-evidencepassed in Chromium at 1440 and 900 desktop widths, 390 mobile and 1024 touch widths. Production template/CSS and prompt/dictation modules were served in a local fixture, with no live service or microphone calls.node --check tests/browser/composerControls.cjsandgit diff --checkpassed.Ship boundary
Minimum ship criteria are compact desktop placement, retained mobile arrangement and usable composer interactions. Broken send/microphone/menu interactions or mobile layout block merge. Coverage is fixture-backed Chromium, not authenticated live-server acceptance, real audio, physical devices or other engines. Footer labels, tray redesign and worker architecture are outside scope. Production deployment is not requested.