Skip to content

Place desktop composer controls beside the draft - #628

Merged
witbrock merged 1 commit into
mainfrom
codex/von-composer-controls
Sep 11, 2026
Merged

witbrock merged 1 commit into
mainfrom
codex/von-composer-controls

Conversation

@witbrock

Copy link
Copy Markdown
Member

Merge decision: ready — desktop users can type and reach send, microphone and a compact More actions disclosure in one composer row; Tier 1 checks support the change.

User outcome

Move the controls beside the desktop draft instead of reserving a separate row. Native task: #V#task_agent_3808f06e4d23b522e46f58e74b101160.

Material changes

Use a two-column desktop composer, including the runtime prompt overlay wrapper. Keep 44-pixel controls and the accessible More actions name; open secondary actions above the composer without expanding it. Attachment and speech status remain full width. Preserve the existing stacked layout on narrow screens and touch devices, using the conversation tray's desktop distinction. No send, speech or tray controller changes.

Evidence

  • 57 tests passed across chatConversationLayout, dictation, voiceConversation, chatTabPromptArrowUpRecall, chatTabSpeechPlanning and promptCartoucheOverlay.
  • node tests/browser/composerControls.cjs /tmp/von-composer-evidence passed in Chromium at 1440 and 900 desktop widths, 390 mobile and 1024 touch widths. Production template/CSS and prompt/dictation modules were served in a local fixture, with no live service or microphone calls.
  • Browser checks cover control placement, accessible names, keyboard focus order, Enter/Space disclosure, send hit target, visible menu actions, dictation start/cancel, Shift-click microphone, draft preservation and tray placement. Desktop idle fixture composer is 66 pixels high, with three 44-pixel targets. Screenshots inspected; menu remains in the viewport without expanding the desktop composer.
  • node --check tests/browser/composerControls.cjs and git diff --check passed.

Ship boundary

Minimum ship criteria are compact desktop placement, retained mobile arrangement and usable composer interactions. Broken send/microphone/menu interactions or mobile layout block merge. Coverage is fixture-backed Chromium, not authenticated live-server acceptance, real audio, physical devices or other engines. Footer labels, tray redesign and worker architecture are outside scope. Production deployment is not requested.

@witbrock
witbrock merged commit b2142ba into main Sep 11, 2026
2 checks passed
@witbrock
witbrock deleted the codex/von-composer-controls branch September 11, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant