Skip to content

Unify conversation discovery and add scoped participant avatars - #630

Merged
witbrock merged 4 commits into
mainfrom
codex/unified-conversations
Sep 11, 2026
Merged

witbrock merged 4 commits into
mainfrom
codex/unified-conversations

Conversation

@witbrock

@witbrock witbrock commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Conversations now includes person/agent message exchanges in the same activity-ordered list as ordinary Von conversations. New visible contributions promote the existing row while selection, drafts, canonical source identities and original reply destinations are preserved.

The shared participant editor supports upload, private image generation preview, publication and removal from Settings, concept views and conversations, with user, organisation, combined and global scopes. Agent access uses the same canonical profile service. Supporting changes include bounded cross-source pagination, exact exchange references, per-viewer read state, shared display names/portraits, Markdown/copy, and organisation recovery from Personal context. Background Settings initialisation now recognises an already established window actor instead of resetting an active conversation.

Native Von task: #V#task_agent_3f9f792044179b8f9c90ebeb121f7784, assigned to Codex VS Code and visible to Michael.

Validation:

  • 355 focused frontend tests and 58 backend tests pass after rebasing onto current main. Six context-binding/rollback regression checks also pass.
  • Python 3.11 grammar compatibility, unchanged PDM lock, diff and changed frontend lint checks pass.
  • Authenticated AgentTest browser checks at 1440×1000 and 390×844. Real background arrivals reached the catalogue in approximately 2.8 seconds; both drafts were retained and precise read acknowledgements read back canonically.
  • Real new-message delivery from Personal context recovered through the shared-organisation chooser and selected the exact canonical exchange. The background Settings reset was reproduced, repaired and replayed successfully.
  • Real generated-avatar publication, Settings upload, concept-view editor and removal all passed, with canonical read-back and an unauthorised other-participant edit denied.
  • One unrelated existing settings-model reload test fails identically on unmodified main (pending.get(...) is not a function); it does not exercise the changed initialisation path and does not change the merge decision.

Merge decision: delivered. Required CI passed on final head 1ddb063d; PR #630 merged as e9e6c03f and was verified on origin/main. The final browser checks above passed; no observed material regression remains on the affected paths. The native task is completed and its completion summary was canonically read back as Michael. AgentTest was stopped and its fixtures were cleaned up.

Bounded behaviour is documented in docs/engineering/unified_conversations_and_participant_profiles.md: filters operate on loaded rows, unread badges show a lower bound while more pages exist, deep-history pins require discovery, and group exchanges remain readable with group reply unavailable. This change does not merge transcripts or deploy a running server.

@witbrock
witbrock force-pushed the codex/unified-conversations branch from f88b923 to 1ddb063 Compare September 11, 2026 22:40
@witbrock
witbrock merged commit e9e6c03 into main Sep 11, 2026
2 checks passed
@witbrock
witbrock deleted the codex/unified-conversations branch September 11, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant