Repository navigation
Add photo upload, face framing and derived avatars (JVNAUTOSCI-2749) - #639
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — the avatar editor gains private photo upload/drop, local face framing with manual correction, and a photo-conditioned generation request with explicit preview/apply.
User outcome
JVNAUTOSCI-2749: create a good-looking avatar from a photo in the existing profile editor. The baseline only centres uploads and generates from text.
Material changes
images.edit, retaininggpt-image-1.5, a single request and no automatic retry. Record private source provenance. The UI explains provider delivery/cost and requires Use avatar; provider failure retains the source and never becomes text-only generation.Evidence
pdm lock --checkandgit diff --checkpass.PYTHONPATH=. pdm run python tests/browser/avatarFixtures.py DIR, thenPLAYWRIGHT_BROWSERS_PATH=/tmp/von-playwright node tests/browser/avatarEditor.cjs DIR.Ship boundary
oauth_token_invalid_grant; assignment text supplied the task scope. The controller owns Von reports/state.