Repository navigation
Keep the collapsible conversation tray clear of active content - #640
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary expansion of the existing collapsible conversation tray could cover the active conversation, and Escape only dismissed hover/focus expansion. Expansion now uses the animated grid column to keep content alongside navigation. Escape also collapses a docked tray when focus is inside navigation, returns focus to its toggle, and leaves conversation-focused Escape alone. The closed toggle is named “Open conversation list”. Existing mobile navigation, persisted preferences, conversation controls and read-state semantics are preserved.
Validation: all 9 targeted tray Jest tests pass; changed-JS static lint and diff checks pass. Production-template Playwright fixture checks pass at 360, 412, 768, 840, 915 and 1440 px, including keyboard close/reopen, selection/unread attribute retention, transcript/draft retention, no overlap and no horizontal overflow. Evidence:
/tmp/von-tray-a2881928. This is isolated fixture acceptance, not authenticated public-service validation. The broader responsive suite hits the same pre-existing keyboard-sized mobile composer/footer assertion with its unchanged test;--tray-onlyruns the bounded tray coverage without that unrelated gate.Merge decision: ready on focused Tier 1 evidence. No deployment requested: the assigned task does not explicitly instruct deployment to the public DGX server.
Von task: #V#task_agent_55599ef461cd33647496cc1b2ce2e1e7 (separate from JVNAUTOSCI-2747).