Repository navigation
Fix conversation discovery results and shared paging (JVNAUTOSCI-2754) - #644
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversation discovery currently rejects normal
conversation_listoutput because the strict gateway schema omits the producer'sorderingfield. Accept that existing field without relaxing unknown-field validation.Also preserve a continuation into the accepted-shared stream when the final owned page exactly fills the requested limit. Previously that boundary could silently omit shared candidates and report complete coverage.
Validation: 51 focused tests pass across discovery gateway, conversation management, search and turn evidence. The new parametrised list/search replay uses real producers and
InternalMCPGateway.invokewith trusted actor context and fixture storage, then the ordinary-turn evidence compactor and cursor resolver. It traverses an empty named-only page, an unnamed owned result, and a shared result; verifies decoded source positions and eventual complete coverage; and rejects cross-actor cursors and prior-turn evidence. Existing naming, membership, duplicate and partial-coverage controls pass.Cursor diagnosis: source keyset positions advance before visible-row filtering; therefore bounded empty pages can be expected. The fixture demonstrates progression, not merely changing signed cursor strings. No loop was demonstrated, and no pager was added. Existing turn evidence preserves coverage and exact cursor recovery without production changes. This does not establish a live corpus census or explain the precise contents of the historical 12 pages.
Merge decision: ready on Tier 1 evidence. No model requests, live data changes, or deployment performed by this worker. After merge the controller is to deploy the exact current-main SHA and verify public and local worker/backend activation, retaining rollback. Native task reporting is owned by the controller.
Tracking: JVNAUTOSCI-2754 / #V#task_agent_47da4c2d72f4b7f31ce71faf1cfbb0a4.