Repository navigation
Preserve conversational diagrams, equations and generated images - #649
Merged
Merged
Conversation
witbrock
force-pushed
the
codex/von-179b0cbd19e2c6f9
branch
from
September 13, 2026 19:31
e60a798 to
5763941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistant replies previously displayed Mermaid/TeX as source and could discard successful image-only provider output. This change renders source-based visuals and preserves ordered text/image results through the ordinary adaptive turn, private image store, display contract and conversation history. Follow-up edits receive retained original pixels and create a separate linked revision.
Native task:
#V#task_agent_0a2baa3bd7a33ac6838d39f6179e05c7— Deliver evolvable conversational diagrams, equations and generated images in Von.Validation:
288a60a7c267730ee1a6f5e8fc372e38759da979: 147 provider/content/display tests and four affected adaptive/actual/von/generatechecks pass. Both required CI checks pass.3e458a78bf86565949bdc6a6de23072b337a892cusing the isolated authenticated Alice fixture. The image was a watercolour octopus with a blue notebook; the edit changed its notebook to green using the retained original. The edit returned no output text, and the image was displayed. Pixels were downloaded and visually inspected, and both checksums matched.gpt-6-astra; requested native image model:gpt-image-2.5-sunburst. Provider items did not independently report an image-model ID. Generation and edit each used one model call, taking approximately 23 seconds each. Usage was retained; exact monetary cost was unavailable from the fixture pricing registry.Real acceptance exposed two repaired defects: response trace redaction treated union-valued JSON Schema
typefields as media discriminators, and empty trailing provider text created invalid display blocks. Regression tests first reproduced both failures and then passed. The final empty-block repair changes display projection only; history/read-back and route fixtures validate it without another paid request. The earlier failed request lost its provider receipt before delivery, so its cost/output remains unknown; it was not automatically retried.Evidence:
.run/visuals649-acceptance-11a33aa2/in the task checkout, including provider summaries, private asset/provenance receipts, final browser screenshots/read-back and test logs. Previous evidence remains in.run/visuals649-integration-dacf8990/and the earlier task runs. The controller retains the task execution archive.Merge decision changes — ready. The ordinary generation/edit acceptance gate is now met, final history/display and actor checks pass, and no demonstrated material regression remains. Candidate frozen at the SHA above.
No public or Mac deployment is requested. Production credentials, model settings and represented guidance are unchanged. Full provider parity, physical-device testing and the documented future multimedia roadmap are outside this delivery.