Repository navigation
Preserve mobile conversation context and remember tray preference - #657
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile conversation navigation previously had no collapse control and could leave the selected conversation outside the visible horizontal list. Keep its current title above the list, reveal the selected tab when rendered/opened, and support collapse/reopen with Escape focus restoration. Conversation ordering and content are unchanged.
Keep the existing mobile open default. Remember mobile collapse separately from desktop using the existing browser-local preference store and page-memory fallback; Settings documents the default, scope across sign-ins and storage fallback. No conversation names or identifiers are persisted by this preference.
Validation: 21 targeted Jest tests pass; changed frontend files pass lint; browser-script syntax and diff checks pass. Production-template Playwright tray checks pass at 320, 360, 412, 768, 840, 915 and 1440 pixels, including long current titles, active-tab visibility, reload persistence, Enter/Space/Escape, document-scroll stability and retained transcript/draft. Also replace an existing layout test's brittle attribute-order assertion with a DOM attribute check.
Merge decision: ready for this bounded Tier 1 refinement. The full responsiveShell check was run and fails its keyboard/footer assertion on both unchanged baseline 56e7a7a and candidate; this unrelated failure does not change the merge decision. Tray-only checks pass all seven profiles. Evidence is synthetic production-template browser acceptance, not authenticated acceptance or public deployment. Existing host browser bridges are bound to other tasks, so none was reused. No deployment requested.
Assigned Von task: #V#task_agent_ba1d58f76f40fb5ea5d3378b7e463bc7.