Repository navigation
Make expanded mobile chat options dismissible - #659
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening mobile composer options kept the same “+”/“More actions” cue and offered no outside-tap dismissal. The toggle now becomes a close icon with a “Close actions” accessible name. Outside clicks and Send dismiss the options, Escape restores toggle focus, and browsers supporting CloseWatcher can handle device Back through their native close-request stack. Drafts and existing submission handlers remain intact.
Dismissal deliberately waits until click activation: collapsing on pointer-down or focus can move Send before a touch click reaches it. No history entries, prompt policy, backend changes or deployment are included.
Validation (Tier 1):
Merge decision: ready; the touch submission regression caught during implementation is repaired and the bounded acceptance checks pass. Browser evidence uses a local production-component fixture, not an authenticated Von server or physically installed PWA. CloseWatcher lifecycle is unit-tested; physical device Back is not claimed. Existing authenticated host bridges target other checkouts and were not repurposed.
Von task: #V#task_agent_55d860ee72cf8465000f59286dbb5db7