Skip to content

Make expanded mobile chat options dismissible - #659

Merged
witbrock merged 1 commit into
mainfrom
codex/von-203cfd443ab02645
Sep 13, 2026
Merged

witbrock merged 1 commit into
mainfrom
codex/von-203cfd443ab02645

Conversation

@witbrock

Copy link
Copy Markdown
Member

Opening mobile composer options kept the same “+”/“More actions” cue and offered no outside-tap dismissal. The toggle now becomes a close icon with a “Close actions” accessible name. Outside clicks and Send dismiss the options, Escape restores toggle focus, and browsers supporting CloseWatcher can handle device Back through their native close-request stack. Drafts and existing submission handlers remain intact.

Dismissal deliberately waits until click activation: collapsing on pointer-down or focus can move Send before a touch click reaches it. No history entries, prompt policy, backend changes or deployment are included.

Validation (Tier 1):

  • 31 tests passed across compactComposer, chatTabSpeechPlanning and chatConversationLayout.
  • Production-template/CSS/module Chromium fixture passed at 360×640, 412×915, 360×360 and 1024×900 with touch, plus 900×900 and 1440×900 desktop.
  • Browser coverage includes repeated touch toggles, accessible close naming, outside tap, Escape/focus, exactly one Send click with the original draft, unchanged compact height, dictation and desktop placement. The baseline failed the new close-name check. Final mobile draft composer heights recover to 62–76px.
  • Static frontend lint and git diff --check passed. Screenshots retained in the worker worktree at .run/composer-dismissal/.

Merge decision: ready; the touch submission regression caught during implementation is repaired and the bounded acceptance checks pass. Browser evidence uses a local production-component fixture, not an authenticated Von server or physically installed PWA. CloseWatcher lifecycle is unit-tested; physical device Back is not claimed. Existing authenticated host bridges target other checkouts and were not repurposed.

Von task: #V#task_agent_55d860ee72cf8465000f59286dbb5db7

@witbrock
witbrock merged commit 5b40b21 into main Sep 13, 2026
2 checks passed
@witbrock
witbrock deleted the codex/von-203cfd443ab02645 branch September 13, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant