Repository navigation
Fix allowed-model persistence and transcription model selection - #662
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — allowing a model now saves and verifies the scoped pool, exposes recoverable failures, and feeds a metadata-filtered recorded-transcription selector.
User outcome
Settings previously staged an additional model indefinitely behind “Pending allowed-model save”. Allow now checks provider discovery and persists immediately, retaining the selected primary and existing alternatives. Failed or unresponsive saves expose a retry or canonical reload action. Task:
#V#task_agent_b637ab307fdc076a6db14d2267092cf7.Material changes
capabilities.audio_transcriptionplus the existing adapter compatibility defaults. Keep effective actor eligibility separate from the administrator's save target.Evidence
git diff --checkpass.tests/browser/modelEnablement.cjs; evidence/tmp/von-model-browser/evidence.jsonand screenshots.Ship boundary
Minimum ship evidence is the tested save/reload/recovery and metadata-filtering path. Lost existing settings, an unusable retry, or selecting a non-transcription model would block delivery; none remains in that path.
Provider catalogue availability is not a quota or inference guarantee. Only the existing OpenAI recorded-file adapter is supported; the selector preference is browser-local. Authenticated live-provider and physical-microphone acceptance were not run: retained host bridges belong to other candidates. No provider generation, credentials, live configuration, database migration or deployment is part of this change. Deployment was not requested.