Repository navigation
Clarify task popup controls and exact-task navigation - #663
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task references now open a popup with visible Refresh and Close labels, keyboard Escape dismissal, outside-pointer dismissal, and focus restoration. The details control explicitly reports Show/Hide details and its expanded state, while a stable viewport-constrained popup prevents expansion from resizing the overlay.
Each popup card has an Open in Tasks action that closes the popup, activates the Tasks tab, and selects the exact task in its inspector, including completed tasks outside the first page or saved filters. Saved filters remain unchanged; the explicitly opened task is included for that workspace visit.
Validation: all 40 tests across seven task-panel suites pass. The new Playwright fixture exercises candidate template, CSS, task component and tab navigation with synthetic read-only API responses at 1440×900, 390×844 and 320×568. It verifies explicit/keyboard/outside dismissal, keyboard details state and focus, exact-task navigation, stable popup dimensions and zero horizontal overflow. Static frontend lint has no errors (three existing unused-catch warnings); git diff --check passes. Evidence is retained in the task worktree at .run/task-popup-controls/.
Merge decision: ready for this Tier 1 interaction/layout slice. Browser evidence is fixture-backed, not authenticated production acceptance. The source-image object was not available in this worker; diagnosis uses the described behaviour and current UI. No deployment requested.