Repository navigation
Implement grounded clarification and durable task continuation - #668
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Von can lose a pending task's identity across a clarification or interrupted creation, and lexical name resolution currently hides lower-ranked visible alternatives. Extend the existing adaptive turn to retain material questions and source-qualified role facts, checkpoint a stable task key before dispatch, and resume through canonical task reconciliation without duplicating confirmed work.
The candidate adds an owner-bound conversation checkpoint using the existing revision-checked carrier;
/generatecarries the resulting revision into terminal persistence. Runtime projections preserve dispatched keys through sidecar omission/truncation, and model-written checkpoints cannot fabricate runtime-fact blocks. A conflicted checkpoint preserves the newer carrier until explicit reconciliation, so a stale terminal sidecar cannot undo a cancellation. Existing current-assignee eligibility, scoped assertions, same-task repairs and model/reasoning preferences remain the effect contracts. The existing turn support message now covers material referents, brief replies, cancellation, provenance, scoped role learning and honest pending outcomes.For Von task
#V#task_agent_7cbf944d3d6c7c8a37817aa48ec594ec; implements the bounded candidate specified by design PR #660. The specification requires no new predicate for this slice. Twenty-two synthetic development cases and an extension to the existing minimal-imposition benchmark summariser separate useful completion, missed/unnecessary questions, incorrect/duplicate effects, evidence kind and comparison arm.Validation: 434 targeted tests pass across adaptive turns, real gateway/native-task fixture continuations, chat carrier CAS, name resolution, scoped assertions, runtime projection, minimal-imposition metrics and
/generatepersistence. Tests include interruption/retry, cancellation conflict, changed membership, count/settings retention, hidden homonyms, forged runtime claims, later scoped role retrieval and attributed correction. PDM lock check, Python 3.11 grammar check (1,531 files), fixture/link validation and diff checks pass. Tests use isolated mock stores and scripted model responses; they launch no coding worker or external model. Updated the impacted route fixture for the current identity-source/window-context contracts.Merge decision: ready for the bounded implementation after the applicable CI checks. Stop-ship conditions are lost task keys/cancellation, duplicate or wrong-scope effects, corrupted provenance, or fabricated runtime facts on the affected path; targeted evidence shows none. Live model clarification quality, indexing, latency/cost and prospective role benefit remain unmeasured and are not claimed. The missing originating transcript and live prompt/alias state were not reconstructed. Semantic guidance stays in the existing code-owned turn support; no second governed prompt is introduced.
The new automatic pre-dispatch checkpoint guarantee is limited to owner-bound ordinary turns; stateless and non-owner calls retain their existing route. A revision is not an execution lock; task identity remains canonical. No deployment, live Vontology mutation, schema migration, membership change or infrastructure activation is requested. Rollback is a code revert plus canonical reconciliation of any persisted task keys/receipts.