Repository navigation
Use readable statement labels in the assertion inspector - #673
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion inspector now uses a readable statement label as its heading, for example “Ada has a paper-matching profile.”, with the full stable assertion ID immediately below. Labels are derived from the existing authorised response, normalised and capped at 96 Unicode code points; the complete statement remains in Summary. Missing statements fall back to “Assertion” plus the full ID.
These are presentation labels, not unique aliases: duplicate or truncated statements remain distinguishable by their displayed full IDs. Copy ID, lookup URLs, stored IDs, provenance and inline machine references remain unchanged. A failed refresh clears the previous label. Long unbroken labels and statements wrap within the panel. No new name registry, backend reads, database changes or deployment.
Validation: 11 reference-inspector Jest tests pass; changed-file static JavaScript lint and diff whitespace check pass. Playwright exercised the actual candidate inspector markup/CSS/module with fixture API and clipboard boundaries: profile, long unbroken statement and fallback at 1280×907 and 390×907; all six cases preserve exact IDs and have no panel horizontal overflow. Local evidence is retained in
.run/assertion-labels/in the controller-owned worktree. This is fixture acceptance, not authenticated/public-server validation.Source limitation: screenshot file copy
#V#computer_file_copy_d5f7f0ba3e1d42728117b0c5a7377195(reported 856×907, SHA-256183a1fa19cc3e1e7f03940c138673c8aef80a41d34d21b49558f02122e938228) was not available in the worker actor scope, so it was not reviewed. Implementation is grounded in the canonical task text and existing inspector code.Task:
#V#task_agent_87e39db5f63ee25ec961405b30a6d396.Merge decision: ready; proportionate Tier 1 evidence supports the bounded inspector display change. Controller owns Von task updates. No deployment requested.