Repository navigation
Keep footer model settings available in message views - #686
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a message exchange added a body class whose CSS hid the persistent model settings button while User, Organisation and Mongo remained visible. Keep the model button available across conversation types, preserving the user's explicit footer visibility preference and existing chat-cost behaviour.
Validation: reproduced the baseline using the actual footer renderer, CSS and message/chat transition functions in a browser source fixture with mocked APIs. The fix passed 14 scenarios covering refresh, delayed/missing metadata, settings access, route transitions, a narrow viewport, explicit hide/restore preferences and native Chromium Ctrl+ zoom at 100/125/150/200/reset100. All 37 focused Jest tests passed; syntax and diff checks passed. Regression harness:
tests/browser/footerModelVisibility.cjs(native zoom uses an isolated DISPLAY and XDOTOOL).Task: #V#task_agent_bb807d511bd9e299705262a8f923a21a. Distinct from completed JVNAUTOSCI-2753 zoom reflow. Evidence retained in the task worktree
.run/footer-model-acceptance.mdand.run/footer-model-{baseline,candidate}/. Original screenshot bytes were not supplied; the reproduced route-dependent mechanism is verified, not the user's exact historical state. No deployment requested.