Repository navigation
Add compact Copy link controls to task details - #688
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task details lacked a copy action in both the popup and the Tasks page. Add the existing tiny concept copy glyph beside the task title, with the shared clipboard fallback/feedback, an announced result, keyboard focus, and 44-pixel touch targets.
The inspected baseline's cartouche action copies a concept ID, and its legacy concept-tab hash decoding cannot preserve underscores. This change therefore introduces one lossless task URL (
?task=%23V%23…#globalTasksTab) and resolves it through the existing scoped task API and Tasks-page selection path, including tasks beyond the first results page. Existing cartouche actions remain unchanged. Denied or mismatched reads do not select a substitute task.Validation: 28 focused frontend tests pass; static lint has no errors (three pre-existing unused-catch warnings). Playwright exercises both surfaces at 1440, 390 and 320 pixels, including clipboard contents, failure/retry, keyboard access, touch target dimensions, exact-task reopening, and popup controls. This is a local fixture with synthetic responses using the example task ID; it is not authenticated real-data acceptance. The localhost-served baseline taskPanel.js SHA256 matches the pre-change repository file.
Authenticated acceptance now passes on exact clean candidate 628f534. The supervisor's retained archive confirms visible browser-test login as the existing authorised actor and successful popup/page clipboard links reopening the real example task through normal startup at 1440 and 390 pixels. Existing membership and example task fields/history were preserved; no model calls or task mutations occurred. Archive #V#computer_file_copy_f19dcf4e7f794dbdaecddafa7fb67a76, SHA256 99e9bc36bfd861279001e26ee610f9fc256a12e1cf784ad363d2dea5b8ac87af, was independently checksum-verified and its audit, acceptance records and screenshots inspected during continuation.
Merge decision changes — authenticated acceptance resolves the remaining blocker; both required CI checks pass and GitHub reports the candidate mergeable. No further implementation is needed. Evidence is local browser-test authentication, not public OAuth or physical-device testing. No public deployment is requested.
Von task: #V#task_agent_2ba5c25aff9135d10d6b69bd42817455