Repository navigation
Replace message attachment bar with an inline plus - #696
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile message replies displayed a full-width “Attach files” bar below the typing field, consuming another row. Replace it with an accessible 44px plus button immediately left of the field in replies and the new-message dialog. Hide the empty preview container and preserve the existing picker, paste/drop, upload and removal handlers.
Validation: 23 existing message-panel frontend tests pass. Browser checks using the production message pane and CSS with synthetic HTTP responses pass for replies and new messages at 320, 390 and 1280px: inline geometry, keyboard picker activation, upload preview and removal. No live messages sent. Deployment is separate.
Von task: #V#task_replace_message_attachment_bar_with_bad09d90