Repository navigation
Fix desktop conversation-end navigation placement and scrolling - #699
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop “Scroll to latest message” occupied a row inside the composer, so toggling it changed the draft height. Its destination was the document bottom, which could leave the conversation above the visible area. Put desktop navigation in a separate sticky transcript host and calculate the destination from the transcript end, composer height and footer clearance. Resize observations keep placement current when attachments or draft controls change size. Compact/mobile navigation retains its existing path.
Validation: 292 chatTab Jest tests passed, targeted frontend static lint and diff checks passed. The new Playwright fixture uses production templates, CSS and the chat navigation module at 1440×900 and 900×900. It checks visible navigation above the composer, end-of-transcript visibility after clicking, unchanged composer height when navigation hides, a 574px attachment draft, short conversations and desktop/mobile/desktop resizing. Retained measurements and screenshots are in the worker's
.run/conversation-end/. This is isolated layout acceptance, not authenticated history or public deployment evidence.Native task: #V#task_agent_86cf55b343ba536ac26940638dc17e5a. All three supplied source screenshots were inspected; their concept IDs and hashes are retained with the evidence. Tier 1 bounded frontend change; no model, authority or persistent state changes. Merge decision: ready after the targeted checks; no deployment requested.