Repository navigation
Render Von concept URLs as navigable concept references - #700
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown references such as
https://von.curiouscat.cc/von/#V#masataro_asairemained ordinary anchors, so the concept annotator skipped them and clicking never reached concept navigation. Normalise recognised Von/von/#V#...anchors into bare concept IDs before the existing annotation pass. Both supplied task/person references now use the existing cartouches and navigation handler; external sources, unrelated paths, query-bearing links, literal code and caller-excluded content retain their existing behaviour.Validation: 51 targeted Jest tests across six suites, changed-file static lint, and an isolated Chromium fixture using the real Markdown renderer, annotator and navigation handler. The task reference reaches the task-panel dependency and Masataro Asai reaches the concept-tab dependency with their exact IDs. External source links retain their href and target. Browser script:
tests/browser/conceptReferenceLinks.cjs.Scope: task
#V#task_agent_51cfbf4527211f2fe45d114ffbfded23. Tier 1 rendering repair. The screen prompt is loaded from live Vontology (von_routes.py); its content and the private concept records are unavailable to this worker. No live prompt was read or changed, and browser metadata/terminal panel dependencies were fixtures. This fixes display independently of prompt wording. No deployment requested.Merge decision: ready after proportionate rendering/navigation checks; live data verification is outside the demonstrated fixture claim.