Repository navigation
Resume conversations after background workflow completion - #703
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attached document's background workflow can outlive the conversation turn, leaving a promise to continue without another turn being queued. This change persists the remaining work in the existing prompt queue and supplies actual document text to workflow consumers independently of indexing.
Behaviour
Native task:
#V#task_resume_authorised_conversation_work_after_f4a22c8d. No event-specific prompt, filename rule, workflow publication or database migration is introduced.Acceptance
Merge decision: ready after the final candidate's required CI passes. The controller-owned recovery dependency is resolved, and the subsequently discovered conversation-attachment early-release defect is repaired.
Targeted tests cover queue durability, interrupted release, duplicate delivery and dispatch, cancellation, prior-effect read-back, foreign scope, revoked membership, source projection and attachment access. The faithful PDF fixture exercises cached and unpersisted text with
conversation_image=true, releases exactly one continuation while the workflow remains in its index step, and supplies usable text to the event workflow launch path. Existing file-reader and upload/preview tests cover the shared reader boundary.Controller evidence for retained candidate
b0047c84b0443976e82f0e595fb20194ec99e9ebindependently verifies a real MongoDB process restart and duplicate-dispatch handoff. It also records actor-scoped recovery of the existing event and 22 programme records, source provenance and exact originating-conversation completion read-back. The verified evidence archive is native attachmentattachment_e2fd81e7811b, SHA-256d8719ea1405dd2467591b4fabba5dfa5830acb9dcf60668808182f7e76d3e4d2. That recovery was controller-operated; it was not automatic production replay. The final local regression tests cover the additional attachment repair.No public deployment is requested or claimed. The launch configuration is Astra/high; provider-observed model identity is unavailable. No additional live model requests were made.
Stop-ship conditions remain lost continuation, duplicate domain effects, cross-actor continuation, discarded source text or unsupported continuation promises on the affected path. Historical indexing performance, unrelated queue work and general workflow redesign remain outside scope.
Final integrated candidate:
2401ff2198f06e999418232213a41c79035133f2.git diff --checkpassed. These local tests use mock storage and scripted model fixtures; they do not claim autonomous production event recovery.