Repository navigation
Fix attachment lifecycle completion and send gating - #713
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Attachment readiness now comes from each draft attachment's lifecycle. Removing an unfinished upload releases Send immediately, even before its batch promise settles; late success/error responses cannot restore the removed attachment. Failed uploads offer retry/removal, and retry completion updates both status and gating. All selected files are registered before yielding so none can escape the gate.
The supplied screenshot contains two distinct PDFs: a ready poster and an uploading programme. It does not establish that the programme upload completed. This change repairs the demonstrated stale batch-gate mechanism and retains the correct gate while another attachment is genuinely uploading.
Validation
node tests/browser/attachmentLifecycle.cjs). Evidence retained in.run/attachment-lifecycle/. This is component acceptance, not authenticated backend or public upload acceptance.Merge decision: ready for the bounded lifecycle/gating claim. No deployment requested.
Von task: #V#task_agent_a847f5aa3de30eaf7453b7ccbaf19fce.
Source screenshot: #V#computer_file_copy_c54e96b78e0c4f58ab8665bab8209db4, SHA-256 c46f4480c94fe297d706abb339c05b8fef9f6b3c31aeaff40cd62cbfe291af36.