Skip to content

Fix attachment lifecycle completion and send gating - #713

Merged
witbrock merged 1 commit into
mainfrom
codex/von-ee089f62d7c7ed41
Sep 15, 2026
Merged

witbrock merged 1 commit into
mainfrom
codex/von-ee089f62d7c7ed41

Conversation

@witbrock

Copy link
Copy Markdown
Member

Outcome

Attachment readiness now comes from each draft attachment's lifecycle. Removing an unfinished upload releases Send immediately, even before its batch promise settles; late success/error responses cannot restore the removed attachment. Failed uploads offer retry/removal, and retry completion updates both status and gating. All selected files are registered before yielding so none can escape the gate.

The supplied screenshot contains two distinct PDFs: a ready poster and an uploading programme. It does not establish that the programme upload completed. This change repairs the demonstrated stale batch-gate mechanism and retains the correct gate while another attachment is genuinely uploading.

Validation

  • 28 tests passed across chatAttachmentWorkflowInput, conversationImageRecovery and conversationVisuals: completion/send, mixed ready/uploading PDFs, failure/retry, removal/cancellation, duplicate and late settlement, conversation isolation, request retry and metadata binding.
  • Changed-file frontend static lint and git diff checks passed.
  • Chromium component check passed using the actual attachment module and local fixture transport (node tests/browser/attachmentLifecycle.cjs). Evidence retained in .run/attachment-lifecycle/. This is component acceptance, not authenticated backend or public upload acceptance.

Merge decision: ready for the bounded lifecycle/gating claim. No deployment requested.

Von task: #V#task_agent_a847f5aa3de30eaf7453b7ccbaf19fce.
Source screenshot: #V#computer_file_copy_c54e96b78e0c4f58ab8665bab8209db4, SHA-256 c46f4480c94fe297d706abb339c05b8fef9f6b3c31aeaff40cd62cbfe291af36.

@witbrock
witbrock merged commit 739f951 into main Sep 15, 2026
2 checks passed
@witbrock
witbrock deleted the codex/von-ee089f62d7c7ed41 branch September 15, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant