INSTRM-3014 Widen candidacy and fix dot cleanup - #25
Open
alefur wants to merge 1 commit into
Open
Conversation
Candidacy allowed a cobra only the spots within its arm length plus a fixed 100 um fudge, so a cobra commanded near full extension lands outside its own radius and its spot is claimed by a neighbour that has no other candidate. Scale the arm length as well, so the allowance grows with the arm rather than staying fixed while the modelled geometry drifts by more. A cobra declared hidden behind a dot removed its own index from potPointMatch, which holds point indices, so it deleted the point of that index from every other cobra's candidate list. Remove it from the points' candidate lists instead, as firstPass does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidacy allowed a cobra only the spots within its arm length plus a fixed 100 um fudge, so a cobra commanded near full extension lands outside its own radius and its spot is claimed by a neighbour that has no other candidate. Scale the arm length as well, so the allowance grows with the arm rather than staying fixed while the modelled geometry drifts by more.
A cobra declared hidden behind a dot removed its own index from potPointMatch, which holds point indices, so it deleted the point of that index from every other cobra's candidate list. Remove it from the points' candidate lists instead, as firstPass does.