Record the boresight the transform ran about - #26
Open
alefur wants to merge 1 commit into
Open
Conversation
The boresight is recomputed for every frame from its altitude, so the parameters alone do not describe the transform that ran. writeTransformToDB sends it to mcs_pfi_transformation alongside them. Drop the write to mcs_boresight. That table is keyed by visit and takes only the first iteration's value, which is neither the calibration nor a record of what the other iterations used; what it should hold instead is a separate question. mcsActor is left with no reference to it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boresight is recomputed for every frame from its altitude, so the parameters alone do not describe the transform that ran. writeTransformToDB sends it to mcs_pfi_transformation alongside them.
Drop the write to mcs_boresight. That table is keyed by visit and takes only the first iteration's value, which is neither the calibration nor a record of what the other iterations used; what it should hold instead is a separate question. mcsActor is left with no reference to it.