Add idempotent seed-data command by Subhransu-De · Pull Request #236 · Subhransu-De/FastAPI-Template

Subhransu-De · 2026-10-02T16:59:41Z

Closes #215

Problem

There was no way to load reference or demo data. Migrations run from their own image, and seeds that insert explicit integer IDs also have to move the identity sequence, or the next insert collides.

Behavior

New seed/ package next to alembic/. It reflects the fixture tables from the database's default schema, so it runs in the migration image without the application code. Tables in other schemas are never seeded.
Contract: every fixture row sets its primary key. Rows are inserted in fixture order with ON CONFLICT (primary key) DO NOTHING in one transaction, tables in foreign-key order. A row whose key exists is left as it is, so a second run inserts nothing. A row without its primary key fails before anything is written.
Each seeded table is locked in SHARE ROW EXCLUSIVE mode for the seed transaction, so concurrent writers and concurrent seed runs wait; readers do not.
For an integer identity primary key, the sequence is restarted after the highest stored ID with ALTER SEQUENCE ... RESTART only when it has not already passed that ID, so it never moves backwards. The restart rolls back with the transaction. This assumes the ascending, step-1 sequence that SQLAlchemy's Identity() creates. The template's own tables use UUID keys and have no sequence.
make seed runs it against .env. In Compose, docker compose run --rm seed runs it from the migration image after migrate. The service is behind the seed profile, so docker compose up does not start it, and nothing in the app lifespan calls it.
seed is added to the ruff and ty lint paths.

Validation

make check: 153 passed, all lint gates green.
make test-integration: 73 passed, including tests/integration/test_seed.py: a second run changes nothing, the next insert after explicit IDs gets a new ID, a sequence that is already ahead is kept, rows without a primary key are rejected, rows with different columns keep their values, fixture order is kept, a same-named table in another schema is not seeded, a rolled-back seed leaves the sequence alone, a concurrent insert waits until seeding commits, and startup does not seed.
Removing the sequence restart, its advance-only condition, the table lock, the default-schema filter, or the primary-key check each makes a test fail.
docker compose run --rm seed twice on a fresh stack: entities: 2 new rows, then entities: 0 new rows.

Note

From claude-opus-5-5

chatgpt-codex-connector · 2026-10-02T16:59:53Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-03T05:17:51.166426Z	`662555e`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

greptile-apps · 2026-10-02T17:03:23Z

Confidence Score: 4/5

[Medium risk] Adds a new database seeding command and fixtures.

The PR is not yet safe to merge because a cached step-1 identity sequence can still produce an ID explicitly inserted by the seed.

Findings

Cached IDs can collide ▶

Fix with agent prompt

### Issue 1
seed/__init__.py:73
If a step-1 identity sequence uses `CACHE 10`, a writer can still hold unused IDs after the sequence reports `last_value = 10`. If seeding inserts one of those IDs, this check treats 11 as the next value and skips the restart. The writer can later receive the seeded ID from its cache, causing a duplicate-key error. The documented step-1 assumption does not rule out caching.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR adds a standalone, transactional fixture seeder, Make and Compose entry points, documentation, and integration coverage. The latest change avoids restarting an identity sequence when its stored state appears to be ahead of the seeded IDs.

_{Reviews (12) · Last reviewed commit: "Only advance identity sequences when see..."}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b225fb350b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T17:08:38Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf67368340

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T17:18:27Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24b73fa533

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T17:27:13Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d95c5dcec3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T17:37:44Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85de8d0f0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T17:50:41Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8339d6ff23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T18:00:29Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f1c65b5bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T18:09:47Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf48606c97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-02T18:19:36Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8459dead60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-03T04:55:45Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb050d7365

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-03T05:06:26Z

@codex review

Note

From claude-opus-5-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bad4f9532f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Subhransu-De · 2026-10-03T05:14:32Z

@codex review

Note

From claude-opus-5-5

sonarqubecloud · 2026-10-03T05:15:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chatgpt-codex-connector · 2026-10-03T05:17:50Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 662555e54b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add idempotent seed-data command

b225fb3

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

Subhransu-De added 2 commits October 2, 2026 22:35

Lock seeded tables while moving sequences

93e74ca

Seed explicit IDs into always-generated identity columns

bf67368

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

Seed rows one at a time and respect sequence direction

24b73fa

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

Batch seed inserts and restart sequences transactionally

d95c5dc

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Keep fixture order and sequence state on seed reruns

85de8d0

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py

Comment thread seed/__init__.py Outdated

Restart sequences on their increment progression

8339d6f

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

Require a conflict key per fixture row and respect sequence bounds

4f1c65b

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

Ignore partial indexes as seed keys and keep restarts in range

bf48606

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Comment thread seed/__init__.py Outdated

Reserve explicit fixture IDs and reject sequence exhaustion

8459dea

greptile-apps Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

chatgpt-codex-connector Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Narrow seeding to primary-key fixtures

bb050d7

chatgpt-codex-connector Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread seed/__init__.py

Seed only fixture tables in the default schema

bad4f95

chatgpt-codex-connector Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread seed/__init__.py Outdated

Only advance identity sequences when seeding

662555e

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread seed/__init__.py

Subhransu-De merged commit 91ca332 into main Oct 3, 2026
40 checks passed

Subhransu-De deleted the add-seed-data-command branch October 3, 2026 05:20

Conversation

Subhransu-De commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Behavior

Validation

Uh oh!

chatgpt-codex-connector Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

greptile-apps Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Subhransu-De commented Oct 2, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Subhransu-De commented Oct 2, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 2, 2026 •

edited

Loading

greptile-apps Bot commented Oct 2, 2026 •

edited

Loading