Skip to content

Fix flaky unit test from aiosqlite failed-connect thread race #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Subhransu-De merged 1 commit into from
Oct 11, 2026
Merged

Fix flaky unit test from aiosqlite failed-connect thread race #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions tests/unit/test_health.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
import threading
from collections.abc import AsyncGenerator

import anyio
import httpx
import pytest
from asgi_lifespan import LifespanManager
Expand All @@ -13,9 +17,19 @@
pytestmark = pytest.mark.unit


def _join_aiosqlite_workers() -> None:
for thread in threading.enumerate():
if thread.name.endswith("(_connection_worker_thread)"):
thread.join(timeout=5)


@pytest.fixture
def unreachable_settings() -> Settings:
return build_settings(database_url=UNREACHABLE_DATABASE_URL)
async def unreachable_settings() -> AsyncGenerator[Settings]:
yield build_settings(database_url=UNREACHABLE_DATABASE_URL)
# A failed aiosqlite connect stops its worker thread without waiting for it
# (omnilib/aiosqlite#394). If this test's event loop closes first, the thread
# raises "Event loop is closed" and pytest blames whichever test runs next.
await anyio.to_thread.run_sync(_join_aiosqlite_workers)


async def test_health_reports_the_application_is_up() -> None:
Expand Down
Loading